[Mlir-commits] [mlir] [mlir][shape] DCE unimplemented extra decl (PR #121275)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sat Dec 28 12:57:57 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-shape

Author: Maksim Levental (makslevental)

<details>
<summary>Changes</summary>

There are no implementations for these methods. This causes linker errors in certain build configurations.

---
Full diff: https://github.com/llvm/llvm-project/pull/121275.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td (-5) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
index 08a0398e74b0cb..8bccba426ab12c 100644
--- a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
+++ b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
@@ -321,11 +321,6 @@ def Shape_DimOp : Shape_Op<"dim",
   let assemblyFormat = "$value `,` $index attr-dict `:` type($value) `,`"
                        "type($index) `->` type($extent)";
 
-  let builders = [
-    // Builder that allows passing a constant dimension as a simple integer.
-    OpBuilder<(ins "Value":$value, "int64_t":$index)>
-  ];
-
   let extraClassDeclaration = [{
     /// Get the `index` value as integer if it is constant.
     std::optional<int64_t> getConstantIndex();

``````````

</details>


https://github.com/llvm/llvm-project/pull/121275


More information about the Mlir-commits mailing list