[Mlir-commits] [mlir] [mlir][emitc] Support convert arith.extf and arith.truncf to emitc (PR #121184)

Marius Brehler llvmlistbot at llvm.org
Sat Dec 28 03:45:19 PST 2024


https://github.com/marbre commented:

Thanks for adding further conversion! Adding a newline to the test would be indeed preferred. i am ooo and need to take a closer look when i am back but I wonder what the expectations with regards to casting and rounding are. `arith.trunc` states
> If the value cannot be exactly represented, it is rounded using the provided rounding mode or the default one if no rounding mode is provided.

but this seems not to be handled in the conversion.

https://github.com/llvm/llvm-project/pull/121184


More information about the Mlir-commits mailing list