[Mlir-commits] [mlir] [mlir][llvmir] implement missing attrs `getChecked` (PR #121248)

Tobias Gysi llvmlistbot at llvm.org
Sat Dec 28 02:03:54 PST 2024


================
@@ -288,6 +288,15 @@ TargetFeaturesAttr TargetFeaturesAttr::get(MLIRContext *context,
                    }));
 }
 
+TargetFeaturesAttr TargetFeaturesAttr::getChecked(
+    llvm::function_ref<::mlir::InFlightDiagnostic()> emitError,
----------------
gysit wrote:

```suggestion
    function_ref<InFlightDiagnostic()> emitError,
```
ultra nit: I think the namespace prefixes are not needed.

https://github.com/llvm/llvm-project/pull/121248


More information about the Mlir-commits mailing list