[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: add missing argument materialization. (PR #121200)

[Benjamin Chetioui]

bchetioui wrote:

> Could you try adjusting this line: https://github.com/openxla/xla/blob/eb9d08bae564680ff465d772ceb70f4d84542e8c/xla/mlir_hlo/mhlo/utils/type_conversion.cc#L112
to add the same function as a source materialization?

Thanks---I did manage to fix that test by changing the converter! (Though what fixed it was instead adding a target materialization---`addTargetMaterialization(scalarToTensor);`.)

At this point, I'm debugging other related failures where this trick doesn't seem to do (and for which I unfortunately don't have shareable reproducers). Nevertheless, I do expect that the issue is similar :)

Thank you @matthias-springer and @zero9178 for the assist, I'll close this now---since it seems unnecessary!

https://github.com/llvm/llvm-project/pull/121200