[Mlir-commits] [flang] [mlir] [mlir][Transforms] Support 1:N mappings in `ConversionValueMapping` (PR #116524)

[Matthias Springer]

================
@@ -1478,34 +1497,12 @@ Value ConversionPatternRewriterImpl::findOrBuildReplacementValue(
   }
   Value castValue = buildUnresolvedMaterialization(
       MaterializationKind::Source, computeInsertPoint(repl), value.getLoc(),
----------------
matthias-springer wrote:

`value` would indeed work as an insertion point for the caller of this function. But `buildUnresolvedMaterialization` will also store the materialization (from `repl` -> original type, not `value` -> original type) in the `mapping`. That's problematic because other parts of the dialect conversion code base are now able to look up the materialization in the `mapping`. And for them the insertion point may not be correct. Again, kind of an edge case here...


https://github.com/llvm/llvm-project/pull/116524