[Mlir-commits] [mlir] [mlir][scf] Add getPartialResultTilePosition to PartialReductionOpInterface (PR #120465)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Dec 23 13:55:48 PST 2024


https://github.com/MaheshRavishankar approved this pull request.

Overall this makes sense. Thanks for the clean up here. THere are still some parts of the code here that might be underspecified, need better comments about what is handled and what is not. That is not due to this change per se, but is just how the current implementation is. Could we make it more clear what the expected/handled cases are? Having examples in comments would help a lot!

https://github.com/llvm/llvm-project/pull/120465


More information about the Mlir-commits mailing list