[Mlir-commits] [mlir] [mlir][scf] Add getPartialResultTilePosition to PartialReductionOpInterface (PR #120465)

[llvmlistbot at llvm.org]

================
@@ -324,7 +324,20 @@ struct LinalgOpTilingInterface
 // External Model for implementing `PartialReductionInterface` for `LinalgOp`s.
 //===----------------------------------------------------------------------===//
 
-/// External model implementation of PartialReductionInterface for LinalgOps.
+static AffineMap getPartialResultAffineMap(LinalgOp linalgOp,
----------------
MaheshRavishankar wrote:

I think this needs more comments. This is assuming that you are doing outer-reduction/inner-parallel. So then it make sense to add as many dimensions here as the number of reduction dimensions to the end of the map. I think this needs to be called out. Comments here would be really useful. This part of the code is really involved and has been a pain to understand since it isnt very well commented.

https://github.com/llvm/llvm-project/pull/120465