[Mlir-commits] [mlir] Remove an assertion on this pointer. (PR #120990)

[Bixia Zheng]

https://github.com/bixia1 created https://github.com/llvm/llvm-project/pull/120990

Remove an assertion on this pointer, as it triggers this error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true.

>From 1df3621566fada793a21301660f879d5eeaf4f67 Mon Sep 17 00:00:00 2001
From: Bixia Zheng <bixia at google.com>
Date: Mon, 23 Dec 2024 18:38:48 +0000
Subject: [PATCH] Remove an assertion on this pointer.

---
 mlir/lib/Transforms/Utils/DialectConversion.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 51686646a0a2fc..255b0ba2559ee6 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2843,7 +2843,6 @@ void TypeConverter::SignatureConversion::remapInput(unsigned origInputNo,
 
 LogicalResult TypeConverter::convertType(Type t,
                                          SmallVectorImpl<Type> &results) const {
-  assert(this && "expected non-null type converter");
   assert(t && "expected non-null type");
 
   {