[Mlir-commits] [mlir] [mlir][Transforms] Dialect Conversion: No target mat. for 1:N replacement (PR #117513)

[Matthias Springer]

================
@@ -2864,6 +2843,9 @@ void TypeConverter::SignatureConversion::remapInput(unsigned origInputNo,
 
 LogicalResult TypeConverter::convertType(Type t,
                                          SmallVectorImpl<Type> &results) const {
+  assert(this && "expected non-null type converter");
----------------
matthias-springer wrote:

I know this is not really needed, but I spent an hour debugging patterns that run without type converters. (Can also be helpful for finding bugs in the dialect conversion framework.) When `convertType` is called on a null type converter, the stack trace looks really odd and makes it look like something is wrong with the caching logic / mutex synchronization inside of `TypeConverter::convertType`.


https://github.com/llvm/llvm-project/pull/117513