[Mlir-commits] [llvm] [mlir] [mlir python] Port in-tree dialects to nanobind. (PR #119924)

Maksim Levental llvmlistbot at llvm.org
Fri Dec 20 05:57:27 PST 2024


makslevental wrote:

> Its weird, with target_include_directories set, it affects the standalone example's python. It looks like the discovery of `_root_dir`.

It's because `INTERFACE` in `INTERFACE_INCLUDE_DIRECTORIES` means "propagate" (roughly I guess). 

So it occurs to me, do we actually need INTERFACE here

```
+  if (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL)
+    set_target_properties(${name} PROPERTIES INTERFACE_COMPILE_OPTIONS "-Wno-cast-qual;-Wno-zero-length-array;-Wno-extra-semi;-Wno-nested-anon-types;-Wno-pedantic")
+  endif()
```

https://github.com/llvm/llvm-project/pull/119924


More information about the Mlir-commits mailing list