[Mlir-commits] [mlir] [mlir] fix crash when scf utils work on llvm.func (PR #120688)

[donald chen]

cxy-1993 wrote:

> It's feels odd to me to create `func.func` when outlining from `llvm.func`, but I suppose we can live with that. The better solution would be to find a way to create a function, and a call to it, of the same kind as the current function, but it is likely impossible without modifications to the function interface. So we can live with what's proposed here + additional lowering.
> 
> Please make sure the test actually tests the change.

Thanks for the comments on this patch. I agree it would be better if we could make a matching function op, but it's hard to do right now.

Regarding your comment on test, it was primarily designed to prevent crashes under llvm func. However, following your suggestion, I've also included checks for outlining.

https://github.com/llvm/llvm-project/pull/120688