[Mlir-commits] [mlir] [mlir] fix crash when scf utils work on llvm.func (PR #120688)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

It's feels odd to me to create `func.func` when outlining from `llvm.func`, but I suppose we can live with that. The better solution would be to find a way to create a function, and a call to it, of the same kind as the current function, but it is likely impossible without modifications to the function interface. So we can live with what's proposed here + additional lowering.

Please make sure the test actually tests the change.

https://github.com/llvm/llvm-project/pull/120688