[Mlir-commits] [llvm] [mlir] [mlir python] Port in-tree dialects to nanobind. (PR #119924)

[Peter Hawkins]

hawkinsp wrote:

> In CMake it is the SYSTEM option of `include_directories`. Since you're including nanobind using find_package, I think you don't have control on this. But you can remap it after find_package in the macro we use to inject the nanobind dependency like this:
> 
> ```
> # Retrieve the include directories set by nanobind
> get_target_property(nanobind_includes nanobind::nanobind INTERFACE_INCLUDE_DIRECTORIES)
> # Apply them as SYSTEM include directories
> target_include_directories(my_target SYSTEM PRIVATE ${nanobind_includes})
> ```

I spent 20 minutes trying to do this and failing. But I admit CMake is completely incomprehensible to me. Is this a hard blocker to landing it?

https://github.com/llvm/llvm-project/pull/119924