[Mlir-commits] [mlir] [mlir][Arith] Remove `arith-to-llvm` from `func-to-llvm` (PR #120548)

[Markus Böck]

zero9178 wrote:

Small heads up: When testing locally on my machine this PR caused crashes in tests for `mlir-vulkan-runner` that see mrelated:
```
Failed Tests (13):
  MLIR :: mlir-vulkan-runner/addf.mlir
  MLIR :: mlir-vulkan-runner/addf_if.mlir
  MLIR :: mlir-vulkan-runner/addi.mlir
  MLIR :: mlir-vulkan-runner/addi8.mlir
  MLIR :: mlir-vulkan-runner/addui_extended.mlir
  MLIR :: mlir-vulkan-runner/mulf.mlir
  MLIR :: mlir-vulkan-runner/smul_extended.mlir
  MLIR :: mlir-vulkan-runner/subf.mlir
  MLIR :: mlir-vulkan-runner/time.mlir
  MLIR :: mlir-vulkan-runner/umul_extended.mlir
  MLIR :: mlir-vulkan-runner/vector-deinterleave.mlir
  MLIR :: mlir-vulkan-runner/vector-interleave.mlir
  MLIR :: mlir-vulkan-runner/vector-shuffle.mlir
```
Error messages are all the same:
```
FAIL: MLIR :: mlir-vulkan-runner/addui_extended.mlir (13 of 2682)
******************** TEST 'MLIR :: mlir-vulkan-runner/addui_extended.mlir' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 4
g:\clion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\mlir-opt.exe G:\CLion\llvm-project\mlir\test\mlir-vulkan-runner\addui_extended.mlir -test-vulkan-runner-pipeline    | mlir-vulkan-runner -      --shared-libs=G:\CLion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\vulkan-runtime-wrappers.dll,G:\CLion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\mlir_runner_utils.dll      --entry-point-result=void | g:\clion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\filecheck.exe G:\CLion\llvm-project\mlir\test\mlir-vulkan-runner\addui_extended.mlir
# executed command: 'g:\clion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\mlir-opt.exe' 'G:\CLion\llvm-project\mlir\test\mlir-vulkan-runner\addui_extended.mlir' -test-vulkan-runner-pipeline
# executed command: mlir-vulkan-runner - '--shared-libs=G:\CLion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\vulkan-runtime-wrappers.dll,G:\CLion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\mlir_runner_utils.dll' --entry-point-result=void
# .---command stderr------------
# | loc("<stdin>":62:12): error: cannot be converted to LLVM IR: missing `LLVMTranslationDialectInterface` registration for dialect for op: arith.constant
# | Error: could not convert to LLVM IR
# `-----------------------------
# error: command failed with exit status: 1
# executed command: 'g:\clion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\filecheck.exe' 'G:\CLion\llvm-project\mlir\test\mlir-vulkan-runner\addui_extended.mlir'
# .---command stderr------------
# | FileCheck error: '<stdin>' is empty.
# | FileCheck command line:  g:\clion\llvm-project\llvm\cmake-build-release-clang-visual-studio\bin\filecheck.exe G:\CLion\llvm-project\mlir\test\mlir-vulkan-runner\addui_extended.mlir
# `-----------------------------
# error: command failed with exit status: 2

```
Don't think pre-commit will catch this IIRC

https://github.com/llvm/llvm-project/pull/120548