[Mlir-commits] [mlir] [mlir] Enable decoupling two kinds of greedy behavior. (PR #104649)

Jakub Kuderski llvmlistbot at llvm.org
Wed Dec 18 20:20:20 PST 2024


kuhar wrote:

> Won't the fold being set to true by default make this an NFC change?

What tripped me is that in `applyPatternsAndFoldGreedily` this PR explicitly sets it to `true`:
```c++
  config.fold = true;
  return applyPatternsGreedily(region, patterns, config, changed);
}
```

@jpienaar could you add a tl;dr section to the PR description that lists the API-level changes and suggests how to integrate this in downstream projects? The motivation is very clear, but what to do with the PR not necesserily.

https://github.com/llvm/llvm-project/pull/104649


More information about the Mlir-commits mailing list