[Mlir-commits] [mlir] [MLIR] Add a BlobAttr interface for attribute to wrap arbitrary content and use it as linkLibs for ModuleToObject (PR #120116)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 8217c2eaef2f93427735a45c45c7fd91178e2ed8 9684a5be7e75c460de09b26dc4e8afa02feada7f --extensions cpp,h -- mlir/include/mlir/Dialect/GPU/IR/CompilationInterfaces.h mlir/include/mlir/Target/LLVM/ModuleToObject.h mlir/include/mlir/Target/LLVM/NVVM/Utils.h mlir/include/mlir/Target/LLVM/ROCDL/Utils.h mlir/lib/Dialect/GPU/IR/GPUDialect.cpp mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp mlir/lib/IR/BuiltinAttributes.cpp mlir/lib/Target/LLVM/ModuleToObject.cpp mlir/lib/Target/LLVM/NVVM/Target.cpp mlir/lib/Target/LLVM/ROCDL/Target.cpp mlir/unittests/Target/LLVM/SerializeNVVMTarget.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp b/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
index 86f741f0b6..f8a548af6b 100644
--- a/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
@@ -71,8 +71,8 @@ void GpuModuleToBinaryPass::runOnOperation() {
   SmallVector<Attribute> librariesToLink;
   for (const std::string &path : linkFiles)
     librariesToLink.push_back(StringAttr::get(&getContext(), path));
-  TargetOptions targetOptions(toolkitPath, librariesToLink, cmdOptions, elfSection,
-                              *targetFormat, lazyTableBuilder);
+  TargetOptions targetOptions(toolkitPath, librariesToLink, cmdOptions,
+                              elfSection, *targetFormat, lazyTableBuilder);
   if (failed(transformGpuModulesToBinaries(
           getOperation(), OffloadingLLVMTranslationAttrInterface(nullptr),
           targetOptions)))

``````````

</details>


https://github.com/llvm/llvm-project/pull/120116