[Mlir-commits] [mlir] [mlir][IR] Turn `FloatType` into a type interface (PR #118891)

Matthias Springer llvmlistbot at llvm.org
Mon Dec 16 01:47:23 PST 2024


matthias-springer wrote:

> The immediate changes here look reasonable. Have you done a sweep of the current users of FloatType to see if any of them should be tightened? Opening up to an interface suddenly expands the contract of FloatType.

>From a user perspective this commit is mostly NFC. It does not matter if you have a concrete type or an interface. The API surface is almost identical. There is only one difference that I found: users can no longer attach an interface to `FloatType`, they have to attach it to a concrete float type (see changed test).


https://github.com/llvm/llvm-project/pull/118891


More information about the Mlir-commits mailing list