[Mlir-commits] [mlir] Check linalg.generic arguments to prevent crashing when they are deleted (PR #119110)

[Andrzej Warzyński]

banach-space wrote:

SG, Renat.

One additional data/design point to keep in mind is that right now, [mlir::isMemoryEffectFree](https://github.com/llvm/llvm-project/blob/f85579fb510faa0a57500b8fd3642f0269c4a4a1/mlir/lib/Interfaces/SideEffectInterfaces.cpp#L309-L331), receives this invalid `linalg.generic`:

```mlir
 "linalg.generic"(<<NULL VALUE>>, <<NULL VALUE>>, <<NULL VALUE>>) <{indexing_maps = [affine_map<(d0, d1, d2) -> (0, d1, d2)>, affine_map<(d0, d1, d2) -> (0, d1, d2)>, affine_map<(d0, d1, d2) -> (d0, d1, d2)>], iterator_types = [#linalg.iterator_type<parallel>, #linalg.iterator_type<parallel>, #linalg.iterator_type<parallel>], operandSegmentSizes = array<i32: 2, 1>}> ({
^bb0(%arg0: i32, %arg1: i32, %arg2: i32):
  "linalg.yield"(<<NULL VALUE>>) : (<<NULL TYPE>>) -> ()
}) : (<<NULL TYPE>>, <<NULL TYPE>>, <<NULL TYPE>>) -> tensor<1x25x13xi32>
```

It shouldn't ;-)

https://github.com/llvm/llvm-project/pull/119110