[Mlir-commits] [mlir] [TOSA] Make validation pass isValidElementType check more strict (PR #119671)

Luke Hutton llvmlistbot at llvm.org
Fri Dec 13 09:24:27 PST 2024


lhutton1 wrote:

Thanks for reporting and for the revert @MaheshRavishankar, apologies I'm only just taking a look now.

I took a look at the failures and noticed that the validation pass is being run over mixed dialect IR. Currently the pass seems to run over all operators regardless of the dialect, including operators from arith/tensor/linalg that use the index type which would be considered illegal in tosa. I suspect we'll need to ensure only tosa operators are checked by this pass - I'll work on a patch for this.

https://github.com/llvm/llvm-project/pull/119671


More information about the Mlir-commits mailing list