[Mlir-commits] [mlir] [mlir][presburger] Preserve relative ordering of symbols and non-symbol vars when setting up SymbolicLexSimplex (PR #119036)

Arjun P llvmlistbot at llvm.org
Thu Dec 12 15:23:14 PST 2024


================
@@ -229,25 +229,17 @@ PresburgerRelation IntegerRelation::computeReprWithOnlyDivLocals() const {
   // SymbolicLexOpt requires these to form a contiguous range.
   //
   // Take a copy so we can perform mutations.
----------------
Superty wrote:

Outdated comment -- please remove this. Could you also update the patch description to say that we are basically updating this function to be more efficient by leveraging the new SymbolicLexOpt API that was added after this function was implemented? The old function did all this swapping because it wasn't previously possible to pass a bit vector.

https://github.com/llvm/llvm-project/pull/119036


More information about the Mlir-commits mailing list