[Mlir-commits] [mlir] [mlir][gpu] Adding ELF section option to the gpu-module-to-binary pass (PR #119440)

[Renaud Kauffmann]

================
@@ -87,16 +87,15 @@ def GpuModuleToBinaryPass
     3. `binary`, `bin`: produces binaries.
     4. `fatbinary`, `fatbin`: produces fatbinaries.
   }];
-  let options = [
-    Option<"toolkitPath", "toolkit", "std::string", [{""}],
-           "Toolkit path.">,
-    ListOption<"linkFiles", "l", "std::string",
-           "Extra files to link to.">,
-    Option<"cmdOptions", "opts", "std::string", [{""}],
-           "Command line options to pass to the tools.">,
-    Option<"compilationTarget", "format", "std::string", [{"fatbin"}],
-           "The target representation of the compilation process.">
-  ];
+  let options =
+      [Option<"toolkitPath", "toolkit", "std::string", [{""}], "Toolkit path.">,
+       ListOption<"linkFiles", "l", "std::string", "Extra files to link to.">,
----------------
Renaud-K wrote:

git-clang-format does that. Will the checks be happy if I undo it? I am afraid not since the diff is now on the radar. Shall I try?

https://github.com/llvm/llvm-project/pull/119440