[Mlir-commits] [mlir] [mlir][spirv] Fix LowerABIAttributesPass to generate EntryPoints for SPV1.4 (PR #118994)

Jakub Kuderski llvmlistbot at llvm.org
Thu Dec 12 08:59:17 PST 2024


================
@@ -93,18 +94,18 @@ getInterfaceVariables(spirv::FuncOp funcOp,
   funcOp.walk([&](spirv::AddressOfOp addressOfOp) {
     auto var =
         module.lookupSymbol<spirv::GlobalVariableOp>(addressOfOp.getVariable());
-    // TODO: Per SPIR-V spec: "Before version 1.4, the interface’s
+    // Per SPIR-V spec: "Before version 1.4, the interface’s
----------------
kuhar wrote:

```suggestion
    // Per SPIR-V spec: "Before version 1.4, the interface's
```

https://github.com/llvm/llvm-project/pull/118994


More information about the Mlir-commits mailing list