[Mlir-commits] [mlir] [mlir][spirv] Fix LowerABIAttributesPass to generate EntryPoints for SPV1.4 (PR #118994)

[Jakub Kuderski]

================
@@ -80,7 +80,8 @@ createGlobalVarForEntryPointArgument(OpBuilder &builder, spirv::FuncOp funcOp,
 /// with an spirv.EntryPointOp. Traverses the body of a entry function to do so.
 static LogicalResult
 getInterfaceVariables(spirv::FuncOp funcOp,
-                      SmallVectorImpl<Attribute> &interfaceVars) {
+                      SmallVectorImpl<Attribute> &interfaceVars,
+                      const spirv::TargetEnv &targetEnv) {
----------------
kuhar wrote:

Can we loo up the target env instead of passing it as a function argument?

https://github.com/llvm/llvm-project/pull/118994