[Mlir-commits] [mlir] [MLIR] Create GPU utils library & move distribution utils (PR #119264)
Kunwar Grover
llvmlistbot at llvm.org
Thu Dec 12 05:28:01 PST 2024
Groverkss wrote:
> @Groverkss, I removed the template parameter for now as the base class passes the warp op to the pattern rewriter anyway. Maybe we shouldn't restrict it to the `OpPatternRewriter` but that seems like a trivial change. I also removed `canBeHoisted` since it's only used in a vector-specific utility (which should be generalized first - I'm thinking about providing a generic distributed type inference utility first and then restricting it to the single dimension case for vector for example).
Fair enough, we can do the templating later. Everything else also sounds good.
https://github.com/llvm/llvm-project/pull/119264
More information about the Mlir-commits
mailing list