[Mlir-commits] [mlir] [mlir][gpu] Adding the ELF section to the NVVMTargetAttr, to propagate to the gpu.binary Op (PR #119440)

[Renaud Kauffmann]

Renaud-K wrote:

The `SelectObjectAttr` does everything we need. Having our own implementation of `OffloadingLLVMTranslationAttrInterface` would lead to a lot of cut-and-paste. This PR is mostly to avoid the cut-and-paste of [`CUFDialectLLVMIRTranslationInterface` ](https://github.com/llvm/llvm-project/blob/main/flang/lib/Optimizer/Dialect/CUF/CUFToLLVMIRTranslation.cpp#L82) that we need downstream to set the ELF section.

My goal is to leverage as much upstream code as possible.

> It's possible to update the attribute, you just need to construct it again.
Would this mean that I would have to replace the gpu.binary op with a new one. 
The blobs attached to them can be huge. Are we confident we will not be duplicating memory passing one to the next?



https://github.com/llvm/llvm-project/pull/119440