[Mlir-commits] [mlir] [mlir][gpu] Adding the ELF section to the NVVMTargetAttr, to propagate to the gpu.binary Op (PR #119440)

[Fabian Mora]

https://github.com/fabianmcg requested changes to this pull request.

Thank you for pushing for this, overall supportive of the idea. However, the section doesn't belong to a target attribute but rather the object attribute.

It's possible to update the attribute, you just need to construct it again.

The other option is adding a pass option `gpu-module-to-binary` to create `gpu.object` with the correct section from the start.

https://github.com/llvm/llvm-project/pull/119440