[Mlir-commits] [flang] [mlir] [MLIR][acc] Introduce varType to acc data clause operations (PR #119007)

Razvan Lupusoru llvmlistbot at llvm.org
Mon Dec 9 12:51:10 PST 2024


razvanlupusoru wrote:

>     * Maybe just leave the standard syntax with the attribute would be clearer but not a strong opinion on that. As I didn't really think about this the syntax proposed didn't feel really obvious but maybe another one would also be ambiguous. Adding a keyword might help but as I mentioned that is just over thinking and could be dealt with in follow up patches.

I attempted to address your concern by adding the "varType" keyword to the printing. It is still optional (if the element's type is encoded in the type of varPtr's target), but at least this fixes the ambiguity when reading the IR. What do you think?

https://github.com/llvm/llvm-project/pull/119007


More information about the Mlir-commits mailing list