[Mlir-commits] [mlir] [MLIR][Arith] Add denormal attribute to binary/unary operations (PR #112700)

[Jakub Kuderski]

kuhar wrote:

My position is that this change seems consistent with the existing philosophy of the arith dialect. Like I summarized [on Discourse](https://discourse.llvm.org/t/rfc-define-precise-arith-semantics/65507/33?u=kuhar), arith is slightly higher level than both LLVM and SPIR-V and is not just a mirror of either of the two. We already have some things that are not trivially mappable to spirv (e.g., anything related to non-standard integer types, freeze semantics (adjacent to arith)). I think we generally have to be careful with these if they have a clear lowering path to llvm and spirv, but both the examples I just listed and denormal flags are fine because they will be decided by some 'frontend' instead of folds or default rewrite patterns. For this reason, I'm fine with this PR and I don't consider it going against any written documentation for arith or be otherwise precedent-setting.

https://github.com/llvm/llvm-project/pull/112700