[Mlir-commits] [mlir] [MLIR] Add allow Insert/extract slice option to pack/unpack op (PR #117340)

[Andrzej Warzyński]

================
@@ -96,6 +96,34 @@ module attributes {transform.with_named_sequence} {
 
 // -----
 
+// This is same as pack_as_pad but since we explicitly added {lowerPadLikeWithInsertSlice = false}, it should not
+// be lowered to insert_slice.
+// CHECK-LABEL: func.func @pack_disallowed_as_pad(
+func.func @pack_disallowed_as_pad(%arg0: tensor<129x47x16x16xf32>, %arg1: tensor<1x1x1x1x136x64x16x16xf32>) -> tensor<1x1x1x1x136x64x16x16xf32> {
----------------
banach-space wrote:

[nit] `@pack_{variant}_as_pad` -> `@pack_as_pad_{variant}`? (`variant` == `disallowed` in this case). Otherwise it's hard to tell which "word" encodes `{variant}`.

Also, `disallowed` -> `disabled_insert_slice`? (`tensor.insert_slice` is still "allowed", but has been explicitly "disabled").

https://github.com/llvm/llvm-project/pull/117340