[Mlir-commits] [mlir] [MLIR] Add allow Insert/extract slice option to pack/unpack op (PR #117340)

Andrzej Warzyński llvmlistbot at llvm.org
Mon Dec 9 01:18:27 PST 2024


https://github.com/banach-space commented:

Thank you for addressing my comments so comprehensively and for splitting your replies into separate commits - makes reviewing so much easier 🙏🏻 

I've left a few minor comments inline, otherwise looks good to me.

> Under such circumstances, such insert and extract slice ops will block producer/consumer fusion tile + fuse transforms.

Somewhat tangential to this PR, but it would be good to document whether this limitation is meant to be lifted at some point?

https://github.com/llvm/llvm-project/pull/117340


More information about the Mlir-commits mailing list