[Mlir-commits] [mlir] [mlir][OpenMP] inscan reduction modifier and scan op mlir support (PR #114737)

[Sergio Afonso]

================
@@ -780,13 +803,15 @@ struct PrivatePrintArgs {
       : vars(vars), types(types), syms(syms) {}
 };
 struct ReductionPrintArgs {
+  ReductionModifierAttr reductionMod;
   ValueRange vars;
   TypeRange types;
   DenseBoolArrayAttr byref;
   ArrayAttr syms;
-  ReductionPrintArgs(ValueRange vars, TypeRange types, DenseBoolArrayAttr byref,
-                     ArrayAttr syms)
-      : vars(vars), types(types), byref(byref), syms(syms) {}
+  ReductionPrintArgs(ReductionModifierAttr reductionMod, ValueRange vars,
----------------
skatrak wrote:

Nit: Perhaps also leave it to the end of the argument list and default-initialize to `nullptr`.
```suggestion
  ReductionPrintArgs(ReductionModifierAttr modifier, ValueRange vars,
```

https://github.com/llvm/llvm-project/pull/114737