[Mlir-commits] [mlir] [mlir][OpenMP] inscan reduction modifier and scan op mlir support (PR #114737)

Sergio Afonso llvmlistbot at llvm.org
Fri Dec 6 05:02:42 PST 2024


================
@@ -491,16 +491,22 @@ struct PrivateParseArgs {
                    SmallVectorImpl<Type> &types, ArrayAttr &syms)
       : vars(vars), types(types), syms(syms) {}
 };
+
 struct ReductionParseArgs {
+  ReductionModifierAttr &reductionMod;
----------------
skatrak wrote:

Nit: It's in a reduction-specific structure, so no need to re-instate that in each variable name. Also, since not every reduction-like clause accepts a modifier, make it a pointer instead.
```suggestion
  ReductionModifierAttr *modifier;
```

https://github.com/llvm/llvm-project/pull/114737


More information about the Mlir-commits mailing list