[Mlir-commits] [mlir] [mlir][OpenMP] inscan reduction modifier and scan op mlir support (PR #114737)

Sergio Afonso llvmlistbot at llvm.org
Fri Dec 6 05:02:42 PST 2024


================
@@ -455,6 +523,7 @@ class OpenMP_InReductionClauseSkip<
   ];
 
   let arguments = (ins
+    OptionalAttr<ReductionModifierAttr>:$in_reduction_mod,
----------------
skatrak wrote:

As far as I can tell, the only clause that takes the reduction modifier, as per the 5.2 spec is `reduction`. I think we should remove the `in_reduction_mod` and `task_reduction_mod` arguments from here, custom parsers including the `in_reduction` and `task_reduction` clauses, etc.

https://github.com/llvm/llvm-project/pull/114737


More information about the Mlir-commits mailing list