[Mlir-commits] [mlir] [mlir][OpenMP] inscan reduction modifier and scan op mlir support (PR #114737)

[Sergio Afonso]

https://github.com/skatrak commented:

Thank you Anchu for working on this, I have some small implementation comments, but I also have some concerns about your proposed representation for `omp.scan`.

Other than that, I'd also suggest adding a not-yet-implemented error in MLIR to LLVM IR translation for the new reduction modifier attributes, and update mlir/test/Target/LLVMIR/openmp-todo.mlir to check for those and for the error that should already be triggered for `omp.scan`.

https://github.com/llvm/llvm-project/pull/114737