[Mlir-commits] [mlir] [mlir][vector][nfc] Update vector-to-llvm.mlir (PR #118112)

[Andrzej Warzyński]

banach-space wrote:

> In terms of remaining inconsistencies, I found
> 
> * inputs named %a, %b, ... (I am ok to have both the (mem, vec, i) naming and argX in the same file)
> * There are some missing delimiter `// -----`

These should be now fixed. 

>   Did you think of something else ?

I think that tests for `vector.fma` should be split into 3 cases:
* 0D vectors,
* 1D vectors,
* 2D vectors.

But I see that as a low priority. Splitting these tests into multiple files would also be a good idea.

https://github.com/llvm/llvm-project/pull/118112