[Mlir-commits] [mlir] [MLIR] Implement emulation of static indexing subbyte type vector stores (PR #115922)

[Andrzej Warzyński]

https://github.com/banach-space commented:

One high-level thing that I don't quite follow - shouldn't `vector.load` also be atomic?

Also, IIUC, the main difference between atomic and non-atomic stores is the presence of  `memref.atomic_rmw`? Perhaps the tests for "atomic" stores could be simplified to only check that the correct ops are generated?

Last, but not least, could you make sure that tests for `vector.store` and `vector.load` are symmetric? The test coverage for these ops should be identical (within reasons). That can only be verified when tests are ... symmetric :)

https://github.com/llvm/llvm-project/pull/115922