[Mlir-commits] [mlir] [mlir][CallGraph] Add edges for callable symbol references in CallGraph (PR #116177)

Markus Böck llvmlistbot at llvm.org
Thu Dec 5 02:17:45 PST 2024


================
@@ -60,8 +62,8 @@ class CallGraphNode {
     };
 
   public:
-    /// Returns true if this edge represents an `Abstract` edge.
-    bool isAbstract() const { return targetAndKind.getInt() == Kind::Abstract; }
+    /// Returns true if this edge represents an `Ref` edge.
----------------
zero9178 wrote:

```suggestion
    /// Returns true if this edge is only a `Ref` edge but not a call or child.
```
Since you mentioned in the description above that Child and Call are are also kinds of references, it probably makes sense to elaborate here. Otherwise we could just `return true` all the time :)

https://github.com/llvm/llvm-project/pull/116177


More information about the Mlir-commits mailing list