[Mlir-commits] [mlir] [mlir][CallGraph] Add edges for callable symbol references in CallGraph (PR #116177)

Markus Böck llvmlistbot at llvm.org
Thu Dec 5 02:17:44 PST 2024


================
@@ -114,6 +121,13 @@ class CallGraphNode {
   /// Returns true if this node has any child edges.
   bool hasChildren() const;
 
+  /// Return true if this node is dead.
+  bool isDead() const { return !isExternal() && getNumReferences() == 0; }
+
+  /// Returns the number of edges in this callgraph that connected
----------------
zero9178 wrote:

```suggestion
  /// Returns the number of edges in this callgraph that refer
```
ultra nit: I feel this more clearly states this considers the directed edges pointing to `*this`

Ditto below for the field

https://github.com/llvm/llvm-project/pull/116177


More information about the Mlir-commits mailing list