[Mlir-commits] [mlir] [MLIR][Arith] Add ExpandOps to convertArithToLLVM (PR #117305)

Mehdi Amini llvmlistbot at llvm.org
Wed Dec 4 08:32:57 PST 2024


joker-eph wrote:

The confusion to me came from comments like:

> I think it is Arith specific and should not be part of generic ConvertToLLVMPass

I think an answer that would have resolved the discussion immediately could have been along the line of: 

> this patch is actually plumbing the new pattern through both passes, since this is adding the call in `ArithToLLVMDialectInterface` as well. The test demonstrates the behavior is consistent between the two passes.

We should be all good now I think.


https://github.com/llvm/llvm-project/pull/117305


More information about the Mlir-commits mailing list