[Mlir-commits] [mlir] [MLIR][Arith] Add ExpandOps to convertArithToLLVM (PR #117305)

[Hugo Trachino]

================
@@ -503,6 +505,7 @@ struct ArithToLLVMDialectInterface : public ConvertToLLVMPatternInterface {
   void populateConvertToLLVMConversionPatterns(
       ConversionTarget &target, LLVMTypeConverter &typeConverter,
       RewritePatternSet &patterns) const final {
+    arith::populateArithExpandOpsPatterns(patterns);
     arith::populateArithToLLVMConversionPatterns(typeConverter, patterns);
   }
 };
----------------
nujaa wrote:

> @nujaa , wouldn't adding this in "ConvertToLLVMPass.cpp" _instead_ also work?

I think it is Arith specific and should not be part of generic ConvertToLLVMPass

https://github.com/llvm/llvm-project/pull/117305