[Mlir-commits] [mlir] [mlir][llvm] Move llvm attribute bases to utils (PR #118491)

Tobias Gysi llvmlistbot at llvm.org
Wed Dec 4 01:09:37 PST 2024


gysit wrote:

> There is also similar tooling for instrinsics, we might want to separate it in a similar manner then too.

Yes the intrinsics use LLVMOpBase.td since the intrinsic base classes share some definitions with the other LLVM dialect operations. 

I am fine with making this new linking attribute dialect dependent on LLVM dialect. That would make the new dialect conceptually similar to the other target dialects. Pointer dialect so far is completely independent of LLVM dialect and I assume that can remain like due the LLVMTranslationDialectInterface. However, that mechanism cannot be use for the sharing tablegen files.

https://github.com/llvm/llvm-project/pull/118491


More information about the Mlir-commits mailing list