[Mlir-commits] [mlir] [mlir][Vector] Update docs for vector.contract extension semantics (PR #118598)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Kunwar Grover (Groverkss)

<details>
<summary>Changes</summary>

This PR clarifies vector.contract extension semantics for floating point types. These added semantics are the ones currently assumed by vector.contract lowerings. Also clarifies that this is a conservative choice, and we would possibly like to extend this in future.

---
Full diff: https://github.com/llvm/llvm-project/pull/118598.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/Vector/IR/VectorOps.td (+4-1) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
index d35847034cb125..e42f13f94f1fb0 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
+++ b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
@@ -58,7 +58,10 @@ def Vector_ContractionOp :
     If operands and the result have types of different bitwidths, operands are
     promoted to have the same bitwidth as the result before performing the
     contraction. For integer types, only signless integer types are supported,
-    and the promotion happens via sign extension.
+    and the promotion happens via sign extension. For floating types, promotion
+    does not consider any fast math / denormal flags. These promotion semantics
+    are restricted choices for now, and in future we would like to extend
+    the operation to carry per-operand extension attributes.
 
     An iterator type attribute list must be specified, where each element of
     the list represents an iterator with one of the following types:

``````````

</details>


https://github.com/llvm/llvm-project/pull/118598