[Mlir-commits] [mlir] [mlir][transform] Guard parametric loop tiling pass from no option (PR #118254)

[Kai Sasaki]

================
@@ -40,6 +40,11 @@ class SimpleParametricLoopTilingPass
   }
 
   void runOnOperation() override {
+    if (sizes.empty()) {
+      getOperation()->emitError("expect non-empty outer loop sizes");
----------------
Lewuathe wrote:

@joker-eph 
When I use the unknown location here, the `expected-error` does not work as expected. The `verify-diagnostics` always prints the error message even if it matches. Is that the limitation of the error verification? Is there anything we can do as a workaround for that?

```
/Users/sasaki/dev/llvm-project/build/bin/mlir-opt -test-extract-fixed-outer-loops /Users/sasaki/dev/llvm-project/mlir/test/Transforms/invalid-outer-loop-size.mlir -verify-diagnostics
<unknown>:0: error: unexpected error: missing `test-outer-loop-sizes` pass-option for outer loop sizes
```

https://github.com/llvm/llvm-project/pull/118254