[Mlir-commits] [llvm] [mlir] [mlir python] Port Python core code to nanobind. (PR #118583)

Stella Laurenzo llvmlistbot at llvm.org
Tue Dec 3 19:16:04 PST 2024


stellaraccident wrote:

Nice! Maks or Peter, I think the PR description could basically just be copy/pasted as an RFC. I would probably add a section for expected steps needed by downstreams (which I think is "none but you may want to port your dialects and eliminate your pybind dep once things land") and rollout plan (which could just be "we will let the final PR sit for at least five days, notify here, and await/incorporate feedback from downstream testing during that period"). I don't anticipate major hurdles but I do know that upstream tests are not comprehensive for all corners of the API or how it is integrated in the wild. Adapting to that is up to the downstreams, but the quality will be better by having a testing period.

https://github.com/llvm/llvm-project/pull/118583


More information about the Mlir-commits mailing list