[Mlir-commits] [mlir] [MLIR] computeSliceParameters: use full slice if affine exprs are non-monotonic (PR #118502)

[llvmlistbot at llvm.org]

================
@@ -581,7 +581,11 @@ computeSliceParameters(OpBuilder &builder, Location loc, Value valueToTile,
   sliceParams.strides.reserve(rank);
   for (unsigned r = 0; r < rank; ++r) {
     LLVM_DEBUG(llvm::dbgs() << "computeSliceParameters: for dim#" << r);
-    if (!isTiled(map.getSubMap({r}), tileSizes)) {
+    auto m = map.getSubMap({r});
+    // The offset & size computation below only handles the case when
+    // the map is monotonically increasing, i.e. the min and max values are
+    // attained at the lower and upper bounds of the iteration domain.
+    if (!isTiled(m, tileSizes) || !m.isComponentWiseMonotonicallyIncreasing()) {
----------------
MaheshRavishankar wrote:

IIUC this will just silently not tile? I think it might be better to error out to avoid having users expect one thing and it silently doing something else?

https://github.com/llvm/llvm-project/pull/118502