[Mlir-commits] [mlir] [MLIR][Arith] Add ExpandOps to convertArithToLLVM (PR #117305)

[Mehdi Amini]

================
@@ -503,6 +505,7 @@ struct ArithToLLVMDialectInterface : public ConvertToLLVMPatternInterface {
   void populateConvertToLLVMConversionPatterns(
       ConversionTarget &target, LLVMTypeConverter &typeConverter,
       RewritePatternSet &patterns) const final {
+    arith::populateArithExpandOpsPatterns(patterns);
     arith::populateArithToLLVMConversionPatterns(typeConverter, patterns);
   }
 };
----------------
joker-eph wrote:

I'm confused because you're only changing the `ArithToLLVMConversionPass` here, so was this behavior already implemented in the `convert-to-llvm` flow and you're just catching up?

(I guess that makes my point as well somehow: we should remove the `convert-arith-to-llvm` pass: it does not provide anything that `convert-to-llvm` can't do, hopefully).

https://github.com/llvm/llvm-project/pull/117305