[Mlir-commits] [mlir] [mlir][Vector] Support mixed mode vector.contract lowering (PR #117753)

[Diego Caballero]

https://github.com/dcaballe requested changes to this pull request.

Hey, thanks a lot for the contribution. As you may know, this has been a controversial topic (actually, I'm not sure if we discussed it in the context of `vector.contract` or linalg at the time). The main problem is this:

> For integer types, only signless integer types are supported, and the promotion happens via sign extension.

If we want to walk this path, we should find a consistent way to represent signed and unsigned extensions per operand (and any potential flags associated with each operand extension, including FP ones). Otherwise, we would need different matches/handling depending on whether the specific extension each operand is going through.

Any ideas to address this issue?

https://github.com/llvm/llvm-project/pull/117753