[Mlir-commits] [mlir] Fix linkage enum attr order to mirror one defined in llvm::GlobalValue (PR #118484)

Tobias Gysi llvmlistbot at llvm.org
Tue Dec 3 05:39:47 PST 2024


https://github.com/gysit approved this pull request.

Thanks LGTM.

We usually use a commit message of the form:

[mlir][llvm] Fix linkage enum order

To clarify that the change is related to MLIR's LLVM dialect. Also the title of the commit should not exceed 72 characters. The commit message can then further detail what the revision is changing. I guess the main argument here is to have the same enum order as in LLVM proper.

https://github.com/llvm/llvm-project/pull/118484


More information about the Mlir-commits mailing list