[Mlir-commits] [mlir] [mlir][affine]make threadid op is valid symbol. (PR #118478)

[lonely eagle]

linuxlonelyeagle wrote:

You're right, as I commented above. But I would like to say that assuming a loadOp or storeOp. assuming that the number of threads is not big enough, then a thread needs to access the data multiple times, then it needs to be implemented with a for loop. the position of the threadid should be aligned with the position of the loadOp and storeOp. Assuming the loadOp is in an affine.for, then the threadid I think should also be in an affine.for, which will cause the check to fail. It is indeed possible to mention the threadid in the funcOp, but this would add extra operations, implemented by looking up its parent op through the op matched in the pattern.
I'm not an expert in the affine, sorry.


https://github.com/llvm/llvm-project/pull/118478