[Mlir-commits] [mlir] [mlir][NFC] Fix format of comments for `foldHook` (PR #118453)
Longsheng Mou
llvmlistbot at llvm.org
Tue Dec 3 03:32:13 PST 2024
https://github.com/CoTinker updated https://github.com/llvm/llvm-project/pull/118453
>From d832e0149f146544d9863b7f234d4a6f33c51e40 Mon Sep 17 00:00:00 2001
From: Longsheng Mou <longshengmou at gmail.com>
Date: Tue, 3 Dec 2024 17:28:48 +0800
Subject: [PATCH 1/2] [mlir][NFC] Fix format of comments for `foldHook`
---
mlir/include/mlir/IR/OperationSupport.h | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/mlir/include/mlir/IR/OperationSupport.h b/mlir/include/mlir/IR/OperationSupport.h
index 1b93f3d3d04fe8..89a2fa985a9693 100644
--- a/mlir/include/mlir/IR/OperationSupport.h
+++ b/mlir/include/mlir/IR/OperationSupport.h
@@ -248,13 +248,11 @@ class OperationName {
///
/// 1. They can leave the operation alone and without changing the IR, and
/// return failure.
- /// 2. They can mutate the operation in place, without changing anything
- /// else
- /// in the IR. In this case, return success.
+ /// 2. They can mutate the operation in-place, without changing anything
+ /// else in the IR. In this case, return success.
/// 3. They can return a list of existing values that can be used instead
- /// of
- /// the operation. In this case, fill in the results list and return
- /// success. The caller will remove the operation and use those results
+ /// of the operation. In this case, fill in the results list and return
+ /// success. The caller will remove the operation and use those results
/// instead.
///
/// This allows expression of some simple in-place canonicalizations (e.g.
>From 238783b2565986eb6512e79a303789ea3b075b3e Mon Sep 17 00:00:00 2001
From: Longsheng Mou <longshengmou at gmail.com>
Date: Tue, 3 Dec 2024 19:32:03 +0800
Subject: [PATCH 2/2] fix typo
---
mlir/include/mlir/IR/OperationSupport.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlir/include/mlir/IR/OperationSupport.h b/mlir/include/mlir/IR/OperationSupport.h
index 89a2fa985a9693..3d99e79c438901 100644
--- a/mlir/include/mlir/IR/OperationSupport.h
+++ b/mlir/include/mlir/IR/OperationSupport.h
@@ -248,7 +248,7 @@ class OperationName {
///
/// 1. They can leave the operation alone and without changing the IR, and
/// return failure.
- /// 2. They can mutate the operation in-place, without changing anything
+ /// 2. They can mutate the operation in place, without changing anything
/// else in the IR. In this case, return success.
/// 3. They can return a list of existing values that can be used instead
/// of the operation. In this case, fill in the results list and return
More information about the Mlir-commits
mailing list